Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off CodeFixes from analyzer #831

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Split off CodeFixes from analyzer #831

merged 1 commit into from
Jan 25, 2025

Conversation

manfred-brands
Copy link
Member

.NET8.0 says there should be no Workspace dependency in an analyzer. CodeFixes should only be loaded by an editor.

Fixes #677

.NET8.0 says there should be no Workspace dependency in an analyzer.
CodeFixes should only be loaded by an editor.
@manfred-brands
Copy link
Member Author

@mikkelbu This splits the analyzer into two projects as per guidelines.
To prevent merge conflicts, I don't really want to start on tickets that create new analyzers until this is in main.
I'm on away on holiday afk for the next two weeks.

@mikkelbu mikkelbu added this to the Release 4.7 milestone Jan 25, 2025
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @manfred-brands. I checked the changes and the renamings and all look good. I also tested it out in VS and it works. So I'll be merging this now

@mikkelbu mikkelbu merged commit 83803de into master Jan 25, 2025
6 checks passed
@Bartleby2718
Copy link
Contributor

@manfred-brands Out of curiosity, where does it say so? The only thing I could find was this sample: https://github.com/dotnet/samples/tree/main/csharp/roslyn-sdk/Tutorials/MakeConst.

@manfred-brands
Copy link
Member Author

@Bartleby2718 It isn't as much that I found a description of it, but it was reported by Roslyn analyzers RS1022: Do not use types from Workspaces assembly in an analyzer and RS1038

The tutorial uses a template that creates a separate assemblies.

@manfred-brands manfred-brands deleted the issue/677_NET8.0SDK branch January 26, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build using .NET8.0 SDK
3 participants